##  ##  
 ##  ##  
 ##  ##  
  ####   
   ##    
         

         
         
 ##  ##  
 ##  ##  
 ######  
 ######  
 ##  ##  
         

       _ 
      | |
      | |
  _   | |
 | |__| |
  \____/ 
         
         

_________
\__   __/
   ) (   
   | |   
   | |   
   | |   
___) (___
\_______/
         

         
|\     /|
| )   ( |
| (___) |
|  ___  |
| (   ) |
| )   ( |
|/     \|
         

IMPORTANT: enter the case-INsensitive alphabetic (no numbers) code AND WRITE SOME SHORT summary of changes (below) if you are saving changes. (not required for previewing changes). Wiki-spamming is not tolerated, will be removed, so it does NOT even show up in history. Spammers go away now.


Visit Preferences to set your user name
Summary of change:
SVN rev. 635 had injector 100% duty related changes (although earlier versions tested fine earlier, extra conditions were added that must hold to switch off injectors.) This change apparently affected ver2.x (the hardware before v3.x) injection => engine flooded (1.0.38 version working correctly). OK solved it myself. <code> uint16_t pwcalc = inj_port->pwcalc; uint16_t now = etime.now; // note, that we do not change inj_port.stopat if we do not schedule // so we don't disturb the turnoff of injector. if (pwcalc){ uint16_t pwcalc, pwd, stopat; </code> pwcalc was introduced again/or not initialised correctly. Just removed second one. (overlapping, I guess it was a compiler warning anyway). Patch available at http://kotisivu.dnainternet.net/sakrkorh/fw/1.0.44/ ... as it is a bit longer than expected, can you explain a few things ? * why wasn't it enough to add 1 ifdef so for v2.x the stop_now() (same as old COND_STOPAT()) is used, not the new injector_should_stop(), injector_should_start() ** I don't understand this, Do you mean that injector_should_stop()& start doesn't work as it should? * any parts of the patch that can effect v3.x ? ** It shouldn't, but can't be sure. All changes are either behind ifdef or added support to use ver3 functions (like digitalout) *** checked the patch and changes doesnt affect ver3. Patch can be added to SVN rep, but i'm not so familiar to SVN so someone else should add it. Although I know only one besides me that uses ver2 board.
Optional: Add document to category:
Wiki formatting: * is Bullet list ** Bullet list subentry ... '''Bold''', ---- is horizontal ruler, <code> preformatted text... </code> See wiki editing HELP for tables and other formatting tips and tricks.